Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add LDAP import command to artisan #6164

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Conversation

epsilon-0
Copy link

Signed-off-by: Aisha Tammy floss@bsd.ac

Checklist

Before submitting the PR

  • Read the CONTRIBUTING document before submitting your PR.
  • If the PR is related to an issue or fix one, don't forget to indicate it.
  • Create your PR as draft if it is not final yet. Mark it as ready... when it’s ready. Otherwise the PR will be considered complete and rejected if it's not working.

General checks

  • Make sure that the change you propose is the smallest possible.
  • The name of the PR should follow the conventional commits guideline that the project follows.

Backend/models changes

  • The API has been updated.
  • API's documentation has been added by submitting a pull request in the marketing website repository.
  • Tests have been added for the new code.
  • If you change a model, make sure the SetupTest file is updated. We need seeders to develop locally and generate fake data.

If the code changes the SQL schema

  • Make sure exporting account data as SQL is still working.
  • Make sure your changes do not break importing data with vCard and .csv files.
  • Make sure account reset and deletion still work.

Other tasks

  • CONTRIBUTORS entry added, if necessary.
  • If it's relevant and worth mentioning, create a changelog entry for this change. The changelog entry will appear inside the UI for all users to see. To know if your change is worth the creation of a changelog entry, read the documentation.
  • Don't forget to ask for a free account on https://monicahq.com as anyone who contributes can request a free account.

@CLAassistant
Copy link

CLAassistant commented May 24, 2022

CLA assistant check
All committers have signed the CLA.

@epsilon-0 epsilon-0 force-pushed the main branch 3 times, most recently from 1f58d66 to 2880063 Compare May 24, 2022 17:43
epsilon-0 added 2 commits May 24, 2022 18:56
Signed-off-by: Aisha Tammy <floss@bsd.ac>
Signed-off-by: Aisha Tammy <floss@bsd.ac>
@epsilon-0 epsilon-0 changed the title add LDAP import command to artisan feat: add LDAP import command to artisan May 24, 2022
@epsilon-0
Copy link
Author

Is there anyway I can help get this pushed forward ?

@asbiin asbiin merged commit 15d7b0e into monicahq:4.x Oct 31, 2023
@asbiin
Copy link
Member

asbiin commented Oct 31, 2023

@epsilon-0 I did not test it, however I don't think it can do any harm, so I'm ok with it :)

@epsilon-0
Copy link
Author

Haha, I agree it doesn't seem like it will do any harm.
I've recently found out about the laravel ldap record - https://github.com/DirectoryTree/LdapRecord-Laravel - which would be the ideal way to implement this. I'll look into doing that enhancement soon :)

Copy link

github-actions bot commented Nov 2, 2024

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants