Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue causing errors about bad return types #109

Conversation

daniell
Copy link
Contributor

@daniell daniell commented Aug 30, 2017

When trying to read an xlsx file, a java.lang.VerifyError is thrown saying that com.monitorjbl.clsc.impl.StreamingSheet.getPaneInformation expects to have a return type of org.apache.poi.hssf.util.PaneInformation but is getting org.apache.poi.ss.util.PaneInformation. This change should fix the issue.

When trying to read an xlsx file, a java.lang.VerifyError is thrown saying that com.monitorjbl.clsc.impl.StreamingSheet.getPaneInformation expects to have a return type of org.apache.poi.hssf.util.PaneInformation but is getting org.apache.poi.ss.util.PaneInformation. This change should fix the issue.
@monitorjbl
Copy link
Owner

Nice catch! Would you mind including a test case with a sheet that has this condition? I don't doubt your change, but there's a lot of different sheets out in the wild. It'd be nice to include one for this case.

@daniell
Copy link
Contributor Author

daniell commented Aug 31, 2017

I'm having problems reproducing the issue in a test environment. It happens consistently when trying to upload a spreadsheet to a web app running on Tomcat 8, but I can't seem to get it to happen at all in tests. Not sure what to do about that.

@monitorjbl
Copy link
Owner

Alright, I'll go ahead and merge it anyway. The change appears to correct an incorrect usage of the hssf package, which is for the old XLS format. That's definitely incorrect for this library as it only supports XLSX (in the xssf package). The ss package is supposed to be the format-agnostic one.

@monitorjbl monitorjbl merged commit c20cd94 into monitorjbl:master Sep 5, 2017
@daniell daniell deleted the fix_issue_with_using_obsolete_pane_information_class branch September 11, 2017 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants