Added support for sheet.getLastRowNum() #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monitorjbl
approved these changes
Sep 26, 2016
|
Sorry for the delay, I've been traveling a lot this month and haven't had time to review PRs in GitHub. Looks good to me! |
|
No prob, glad to hear that the PR is accepted :)
|
rimuln
pushed a commit
to rimuln/excel-streaming-reader
that referenced
this pull request
Nov 15, 2021
Bumps [slf4j-api](https://github.com/qos-ch/slf4j) from 1.7.31 to 1.7.32. - [Release notes](https://github.com/qos-ch/slf4j/releases) - [Commits](https://github.com/qos-ch/slf4j/commits) --- updated-dependencies: - dependency-name: org.slf4j:slf4j-api dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Great work on this project, it really simplifies reading a workbook which used to be pretty low-level.
This pull request is regarding adding support for getLastRowNum. I specifically aimed on this method as it is used to report the total number of rows back to the user. This can in turn be used to show a progress bar and estimate remaining time.
It basically picks the ref attribute from the dimension element at the top of a sheet. This is formatted as 'A1' or A1:A3000'. Either way, we're only interested in the last number (and subtract 1 so that we get a 0-based row index).
The implementation of StreamingSheetReader.handleEvent captures this 'dimension' element.
A test case was added that tests a sheet with rows, as well as a sheet containing only one row.
Hope you like it :)
(edit: re-opened this pull request as it appeared to break a test ... what was I thinking? probably time for weekend!)