Changes to enable 1904-based dates #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monitorjbl
reviewed
Jan 22, 2017
| } catch(RuntimeException e) { | ||
| f.delete(); | ||
| throw e; | ||
| private static final Logger log = LoggerFactory.getLogger(StreamingWorkbookReader.class); |
There was a problem hiding this comment.
It's really hard to tell what changed here because it looks like you re-indented the entire file and re-ordered the methods. Can you please update this to use two-space indents and keep the original ordering?
There was a problem hiding this comment.
Hurm, it appears my IDE got overly aggressive. I've reverted the change and reapplied the fix. We should be good to go now.
monitorjbl
reviewed
Jan 22, 2017
| } | ||
| } | ||
| @Test | ||
| public void testGetDateCellValue1904() throws Exception { |
There was a problem hiding this comment.
Thanks for including a test case!
There was a problem hiding this comment.
Wouldn't dream of offering a pull request without one
monitorjbl
requested changes
Jan 22, 2017
monitorjbl
approved these changes
Jan 23, 2017
|
Awesome, thanks. Whenever you have a chance to get it up on Maven Central, that would help me out a lot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.