-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automerged branches are not automerged when a build completes #2
Comments
For reference, as of Stash 3.6.1 there is no event to listen to for builds. |
It looks like it's possible to have an event listener for all build events: https://developer.atlassian.com/static/javadoc/stash/3.10.0/build-integration/reference/com/atlassian/stash/build/BuildStatusSetEvent.html |
Just wonder if there is no build associated with the repo, will a PR get auto-merged? Seems not working here. |
The plugin listens only to approval events in the latest release. This is fine for simple cases, but if you've configured your repo to block PRs until there's a successful build then the PR won't automerge. It's kind of a pain if you've got a full CI workflow. There is a build complete event hook as of Stash 3.9.1. With that, the plugin can trigger an automerge if the PR is approved. |
I'm going to wait to fix this until version 1.5. It will break compatibility with Stash 3.6 and I want to get the other issues for 1.4 resolved without requiring a version upgrade of Stash. |
If a PR is approved and waiting on a build to complete before merging, the automerge functionality does not detect when the build completes successfully.
The text was updated successfully, but these errors were encountered: