Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish for Scala 2.13.0-M5? #23

Closed
SethTisue opened this issue Jul 11, 2018 · 14 comments
Closed

publish for Scala 2.13.0-M5? #23

SethTisue opened this issue Jul 11, 2018 · 14 comments

Comments

@SethTisue
Copy link
Contributor

SethTisue commented Jul 11, 2018

I think your dependencies are available for M4 now? (not 100% sure)

in the Scala 2.13 community build, at e.g. https://scala-ci.typesafe.com/job/scala-2.13.x-integrate-community-build/1228/consoleFull, I'm seeing that getting minitest onto the new collections would also help unlock a bunch of downstream projects. (most of which need cats too, but cats isn't too far from being able to publish, too.)

[info] Project ammonite--------------------: DID NOT RUN (stuck on broken dependencies: minitest, scala-async, spray-json, tut, utest)
[info] Project better-monadic-for----------: DID NOT RUN (stuck on broken dependencies: cats, minitest, pcplod)
[info] Project eff-------------------------: DID NOT RUN (stuck on broken dependencies: cats, minitest)
[info] Project fs2-reactive-streams--------: DID NOT RUN (stuck on broken dependencies: cats, minitest, scodec-bits, utest)
[info] Project giter8----------------------: DID NOT RUN (stuck on broken dependencies: cats, grizzled, minitest, scalamock, utest)
[info] Project http4s----------------------: DID NOT RUN (stuck on broken dependencies: cats, http4s-parboiled2, log4s, minitest, scodec-bits, spray-json, twirl, utest)
[info] Project kxbmap-configs--------------: DID NOT RUN (stuck on broken dependencies: cats, minitest, utest)
[info] Project minitest--------------------: FAILED (RuntimeException: )
[info] Project monix-----------------------: DID NOT RUN (stuck on broken dependencies: cats, minitest)
[info] Project sbinary---------------------: DID NOT RUN (stuck on broken dependencies: cats, minitest, utest)
[info] Project sbt-------------------------: DID NOT RUN (stuck on broken dependencies: cats, minitest, spray-json, utest)
[info] Project sbt-io----------------------: DID NOT RUN (stuck on broken dependencies: cats, minitest, utest)
[info] Project sbt-librarymanagement-------: DID NOT RUN (stuck on broken dependencies: cats, minitest, spray-json, utest)
[info] Project sbt-util--------------------: DID NOT RUN (stuck on broken dependencies: cats, minitest, spray-json, utest)
[info] Project scala-debugger--------------: DID NOT RUN (stuck on broken dependencies: minitest, scala-async, scalamock, scallop, spray-json, tut, utest)
[info] Project scala-ssh-------------------: DID NOT RUN (stuck on broken dependencies: cats, minitest, utest)
[info] Project scalafmt--------------------: DID NOT RUN (stuck on broken dependencies: cats, minitest, utest)
[info] Project scalaprops------------------: DID NOT RUN (stuck on broken dependencies: cats, minitest, utest)
[info] Project scopt-----------------------: DID NOT RUN (stuck on broken dependencies: minitest, utest)
[info] Project sttp------------------------: DID NOT RUN (stuck on broken dependencies: akka-actor, cats, minitest, scodec-bits, spray-json)
[info] Project zinc------------------------: DID NOT RUN (stuck on broken dependencies: cats, minitest, spray-json, utest)
@xuwei-k
Copy link
Contributor

xuwei-k commented Jul 11, 2018

#19

[minitest] [error] 'by-name-right-associative' is not a valid choice for '-Xlint'
[minitest] [error] 'unsound-match' is not a valid choice for '-Xlint'

@SethTisue
Copy link
Contributor Author

SethTisue commented Aug 2, 2018

after #19 was merged, I tried the Scala 2.13 community build and got:

[minitest] [error] /Users/tisue/community.213/target-0.9.12/project-builds/minitest-140990deb8a820140508cf1c8a3f44a72fc477aa/shared/src/main/scala/minitest/runner/Framework.scala:30:5: trait Runner is abstract; cannot be instantiated
[minitest] [error]     new Runner(args, remoteArgs, testClassLoader)
[minitest] [error]     ^
[minitest] [info] No documentation generated with unsuccessful compiler run
[minitest] [error] one error found
[minitest] [error] /Users/tisue/community.213/target-0.9.12/project-builds/minitest-140990deb8a820140508cf1c8a3f44a72fc477aa/shared/src/main/scala/minitest/runner/Framework.scala:30:5: trait Runner is abstract; cannot be instantiated
[minitest] [error]     new Runner(args, remoteArgs, testClassLoader)
[minitest] [error]     ^

this looks a consequence of scala/scala#6589; import sbt.testing.{Framework => BaseFramework, _} is importing Runner and then (after PR 6589) that shadows minitest.runner.Runner

note that 6589 was merged post-M4, so you won't actually hit this when publishing for M4

@SethTisue
Copy link
Contributor Author

SethTisue commented Aug 2, 2018

if I run the community build now with version=2.13.0-M4 I get:

[info] Project minitest--------------------: SUCCESS (project rebuilt ok)

so that's promising.

@SethTisue SethTisue changed the title publish for Scala 2.13.0-M4? publish for Scala 2.13.0-M5? Sep 27, 2018
@SethTisue
Copy link
Contributor Author

minitest remains green in the 2.13 community build. I've updated this ticket name now that Scala 2.13.0-M5 is out

@SethTisue
Copy link
Contributor Author

scalacheck needs to publish first, I think. typelevel/scalacheck#418

@SethTisue
Copy link
Contributor Author

ScalaCheck 1.14.0 is now published for M5 (both JVM & JS), so this should be unblocked now, I think?

@SethTisue
Copy link
Contributor Author

@alexandru anything you could use community help with, here?

@ashawley
Copy link
Contributor

@SethTisue Can you review #30?

@SethTisue
Copy link
Contributor Author

SethTisue commented Oct 26, 2018

@ashawley done (I ✅'ed)

@SethTisue
Copy link
Contributor Author

ticket is closed, but I don't see artifacts at https://repo1.maven.org/maven2/io/monix/minitest_2.13.0-M5 ?

@alexandru alexandru reopened this Oct 27, 2018
@alexandru
Copy link
Member

@SethTisue I don’t remember closing it, however I’ll publish it tomorrow.

@alexandru
Copy link
Member

@SethTisue I published it with version 2.2.2

@SethTisue
Copy link
Contributor Author

awesome! scala/make-release-notes@32059ea

dejan2609 added a commit to dejan2609/kafka that referenced this issue Feb 26, 2019
details:
  * build expanded in order to use Scala 2.13 milestone version (version 2.13.0-M5 is used)
  * 'scoverage' version upgraded: 1.3.1 -->> 1.4.0-M5
  * Scala 2.13 build only: Xlint options 'by-name-right-associative' and 'unsound-match' are removed (related: monix/minitest#23 (comment))
@dejan2609
Copy link

Sorry for additional noise (spamming), I should have known better 😟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants