Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework burst heatmap to not allow negative ranges #4678

Closed
monkeytypegeorge opened this issue Sep 28, 2023 · 4 comments
Closed

Rework burst heatmap to not allow negative ranges #4678

monkeytypegeorge opened this issue Sep 28, 2023 · 4 comments

Comments

@monkeytypegeorge
Copy link
Collaborator

monkeytypegeorge commented Sep 28, 2023

Currently, if there is a very slow and a very fast word in the history, its possible for the website to show weird ranges. Also things behave weirdly with very short tests, or tests where the speed is very consistent (which also means its hard to divide into 5 brackets). Easily testable with a 3 word test where 2 of them are slow.

@Miodec
Copy link
Member

Miodec commented Sep 28, 2023

image

With burst wpms: 26, 49, 273

@sanidhyas3s
Copy link
Contributor

So the proposed fix is to not allow negative range and start from 0 or 1 wpm? Or some other fundamental changes?

@clarkWakeland
Copy link

clarkWakeland commented Sep 30, 2023

The issue is a result from the lower bound on the heatmap being median(burstlist) - step*1.5 , which produces a negative value if the mean deviation (step) is too large. My proposed change is to just start at 0 and increase by step * 0.5 each increment if the lower bound would otherwise be negative.

Here's my result with my changes for burst wpms: 43, 36, 269
image

Could I be assigned this issue?

@Miodec
Copy link
Member

Miodec commented Oct 2, 2023

The issue is a result from the lower bound on the heatmap being median(burstlist) - step*1.5 , which produces a negative value if the mean deviation (step) is too large. My proposed change is to just start at 0 and increase by step * 0.5 each increment if the lower bound would otherwise be negative.

Here's my result with my changes for burst wpms: 43, 36, 269 image

Could I be assigned this issue?

This solution is close, but ideally i would like to avoid the first two brackets being essentially the same. Plus, the first bracket is "less than zero" which kidna makes no sense.

Ideally i would like the first bracket to be something like < (a little bit over min speed), so for example if our min speed was 15, i would like the first bracket the be < 24 (in this example, there is no relation between 15 and 24, just random numbers)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants