fix: use selected typing speed unit on personal best popup (fehmer) #5070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fehmer
force-pushed
the
feature/fix-pb-typing-unit
branch
2 times, most recently
from
3a44525 to
8d9bddb
Compare
fehmer
force-pushed
the
feature/fix-pb-typing-unit
branch
from
8d9bddb to
dfd82fc
Compare
fehmer
commented
Feb 17, 2024
fehmer
commented
Feb 17, 2024
fehmer
changed the title
Miodec
reviewed
Feb 19, 2024
Miodec
changed the title
Miodec
pushed a commit
that referenced
this pull request
Feb 19, 2024
…5070) * fix: Use selected typing speed unit on personal best popup * refactor * refactor * test coverage * use Format in more places * Make config mockable * dependency injection * wip * fix * test * touch
Miodec
added a commit
that referenced
this pull request
Feb 19, 2024
* move user to shared definitions this includes whatever user can have on it, tags, presets and so on * profiles, mail and others * fix logic * yeet * same as master for now * tsc fixes * remove comment * fix tests * chore: omit ips * fix(language): remove some unnecessarily capitalised words in german 1k * fix(typing): first space sometimes soft locking the website * perf: speed up settings page loading * fix: use selected typing speed unit on personal best popup (fehmer) (#5070) * fix: Use selected typing speed unit on personal best popup * refactor * refactor * test coverage * use Format in more places * Make config mockable * dependency injection * wip * fix * test * touch * fix(language): typos in russian_10k.json (kae) (#5082) * Update russian_10k.json - fixed typos - removed duplicates * - fixed extra typos * remove duplicates * fix(language): typos in russian_10k.json * feat: add copy missed words to result screen (fehmer) (#5086) * feat: Add copy missed words to result screen * remove margin * update icons --------- Co-authored-by: Miodec <jack@monkeytype.com> * impr(funbox): add 46 group languages to wikipedia funbox (RealCyGuy) (#5078) * impr: provide all-time LB results during LB update (fehmer) (#5074) Try to provide LB results during the LB update. There is a very small time-frame where already running queries might fail during the update. For now we keep the 503 error in this cases and monitor how often this happens on production. * impr(funbox): add ` (grave accent, 96) and ~ (tilde, 126) to specials (#5073) * impr: add testWords and wordsHistory to copy result stats (#5085) * feat: add testWords and wordsHistory to copy result stats * fix * add fe ts dep --------- Co-authored-by: Christian Fehmer <fehmer@users.noreply.github.com> Co-authored-by: Andrey Kuznetsov <akuznetsov@outlook.com> Co-authored-by: Cyrus Yip <cyruscmyip1@gmail.com> Co-authored-by: fitzsim <fitzsim@fitzsim.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #5059