Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: shared user types #5080

Merged
merged 21 commits into from
Feb 19, 2024
Merged

refactor: shared user types #5080

merged 21 commits into from
Feb 19, 2024

Conversation

Miodec
Copy link
Member

@Miodec Miodec commented Feb 19, 2024

Description

Last one baby.

Closes #4774.
Closes #4786.

this includes whatever user can have on it, tags, presets and so on
@monkeytypegeorge monkeytypegeorge added backend Server stuff frontend User interface or web stuff labels Feb 19, 2024
@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/7953074475

@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/7960675375

@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/7961550820

@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/7961918597

@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/7962063154

1 similar comment
@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/7962063154

Miodec and others added 11 commits February 19, 2024 17:04
…5070)

* fix: Use selected typing speed unit on personal best popup

* refactor

* refactor

* test coverage

* use Format in more places

* Make config mockable

* dependency injection

* wip

* fix

* test

* touch
* Update russian_10k.json

- fixed typos
- removed duplicates

* - fixed extra typos

* remove duplicates

* fix(language): typos in russian_10k.json
* feat: Add copy missed words to result screen

* remove margin

* update icons

---------

Co-authored-by: Miodec <jack@monkeytype.com>
Try to provide LB results during the LB update. There is a very small time-frame where
already running queries might fail during the update. For now we keep the 503 error in this
cases and monitor how often this happens on production.
* feat: add testWords and wordsHistory to copy result stats

* fix
@Miodec Miodec merged commit 01790d8 into master Feb 19, 2024
6 checks passed
@Miodec Miodec deleted the shared-user-types branch February 19, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Server stuff frontend User interface or web stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add API response types to the frontend Move duplicated types to the shared types definitions
6 participants