Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add API response types to the frontend #4786

Closed
9 of 10 tasks
monkeytypegeorge opened this issue Nov 13, 2023 · 5 comments · Fixed by #5080
Closed
9 of 10 tasks

Add API response types to the frontend #4786

monkeytypegeorge opened this issue Nov 13, 2023 · 5 comments · Fixed by #5080
Assignees
@Miodec

Comments

@monkeytypegeorge
Copy link
Collaborator

monkeytypegeorge commented Nov 13, 2023 •
edited by Miodec
Loading

This is quite a big issue, if you wish to work on it, lets split it into parts:

  • users
  • configs
  • results
  • psas
  • quotes zaitsev-oleksii
  • leaderboards
  • presets
  • publicStats
  • apeKeys
  • configuration
@Amanshenoy008
Copy link

Hey, can I work on results part

@akash942
Copy link

hey @monkeytypegeorge can you elaborate more about the issue what do you mean by API response types or maybe point me to the right resources I am new here and trying to make my first open source contribution quite familiar with node

@Miodec
Copy link
Member

Miodec commented Jan 15, 2024 •
edited
Loading

hey @monkeytypegeorge can you elaborate more about the issue what do you mean by API response types or maybe point me to the right resources I am new here and trying to make my first open source contribution quite familiar with node

The frontend API functions currently are not typed, meaning that there is no type safety when using these functions.

image

As you can see here, data is any.

image image

@zaitsev-oleksii
Copy link
Contributor

Hey, can I take quotes part?

@zaitsev-oleksii zaitsev-oleksii mentioned this issue Jan 29, 2024
Merged
8 tasks
Miodec added a commit that referenced this issue Feb 7, 2024
@Miodec
impr(types): add frontend config API response types
1ee0588 
part of #4786
Miodec added a commit that referenced this issue Feb 7, 2024
@Miodec
refactor(types): PSA types
65120db 
move to shared types (#4774)
add types to ape client (#4786)
Miodec added a commit that referenced this issue Feb 7, 2024
@Miodec
refactor(types): public types
efb972a 
move to shared types (#4774)
add types to ape client (#4786)
Miodec added a commit that referenced this issue Feb 7, 2024
@Miodec
refactor(types): ape keys types
4f5f28a 
move to shared types (#4774)
add types to ape client (#4786)
Miodec added a commit that referenced this issue Feb 7, 2024
@Miodec
refactor(types): server configuration types
315b7f7 
add types to ape client (#4786)
@Miodec Miodec mentioned this issue Feb 8, 2024
Merged
Miodec added a commit that referenced this issue Feb 8, 2024
@Miodec
refactor(types): leaderboard types
15c6978 
move to shared types (#4774)
add types to ape client (#4786)
@Miodec
Copy link
Member

Miodec commented Feb 8, 2024

@Amanshenoy008 unassigning you from the results section due to inactivity

Miodec added a commit that referenced this issue Feb 8, 2024
@Miodec
refactor(types): result types
e316135 
move to shared types (#4774)
add types to ape client (#4786)
@Miodec Miodec self-assigned this Feb 14, 2024
@Miodec Miodec mentioned this issue Feb 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Miodec Miodec

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: shared user types monkeytypegame/monkeytype
5 participants
@Miodec @akash942 @monkeytypegeorge @zaitsev-oleksii @Amanshenoy008