Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(quotes): add Kotlin quotes (Fynn-Pritzkau) #4942

Merged
merged 11 commits into from
Jan 29, 2024

Conversation

Fynn-Pritzkau
Copy link
Contributor

@Fynn-Pritzkau Fynn-Pritzkau commented Jan 18, 2024

feat: Kotlin Quotes Initialization (Fynn-Pritzkau)

Description

Added three quotes to the Kotlin language.

Checks

  • Adding a language or a theme?
    • If is a language, did you edit _list.json, _groups.json and add languages.json?
    • If is a theme, did you add the theme.css?
      • Also please add a screenshot of the theme, it would be extra awesome if you do so!
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username inside parentheses at the end of the PR title

@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels Jan 18, 2024
@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/7571750479

@Fynn-Pritzkau Fynn-Pritzkau reopened this Jan 18, 2024
@Fynn-Pritzkau Fynn-Pritzkau reopened this Jan 18, 2024
@Fynn-Pritzkau Fynn-Pritzkau reopened this Jan 18, 2024
@Fynn-Pritzkau Fynn-Pritzkau changed the title Kotlin quotes feat: Kotlin Quotes Initialization (Fynn-Pritzkau) Jan 18, 2024
@Miodec
Copy link
Member

Miodec commented Jan 22, 2024

I think it would be good to start with a few more quotes

@Miodec Miodec added the waiting for update Pull requests or issues that require changes/comments before continuing label Jan 22, 2024
@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/7630484604

@Fynn-Pritzkau
Copy link
Contributor Author

i will add more tomorrow

@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/7665127300

@Miodec Miodec changed the title feat: Kotlin Quotes Initialization (Fynn-Pritzkau) feat(quotes): add Kotlin quotes (Fynn-Pritzkau) Jan 29, 2024
@Miodec Miodec merged commit 3c03478 into monkeytypegame:master Jan 29, 2024
8 checks passed
@Miodec
Copy link
Member

Miodec commented Jan 29, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assets Languages, themes, layouts, etc. frontend User interface or web stuff waiting for update Pull requests or issues that require changes/comments before continuing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants