Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(language): add code v (Dlurak) #4957

Merged
merged 4 commits into from
Jan 29, 2024
Merged

feat(language): add code v (Dlurak) #4957

merged 4 commits into from
Jan 29, 2024

Conversation

Dlurak
Copy link
Contributor

@Dlurak Dlurak commented Jan 23, 2024

Description

I've added the (programming) language V.

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language or a theme?
    • If is a language, did you edit _list.json, _groups.json and add languages.json?
    • If is a theme, did you add the theme.css?
      • Also please add a screenshot of the theme, it would be extra awesome if you do so!
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username inside parentheses at the end of the PR title

@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels Jan 23, 2024
@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/7629507664

@Dlurak
Copy link
Contributor Author

Dlurak commented Jan 23, 2024

I've addressed and fixed the issue

@Miodec
Copy link
Member

Miodec commented Jan 24, 2024

Is all the keywords that are available? With only 20 words there will be alot of repetition.

@Miodec Miodec added the waiting for update Pull requests or issues that require changes/comments before continuing label Jan 24, 2024
All keywords, all types and some built in functions are now included
@Dlurak
Copy link
Contributor Author

Dlurak commented Jan 24, 2024

I've just checked the docs, V has 44 keywords and some types which I all added. Also the json file now includes more built in functions.

@Dlurak
Copy link
Contributor Author

Dlurak commented Jan 25, 2024

Are there any problems left?
This PR still has the "waiting for an update" label

@Miodec Miodec changed the title chore: Add the V programming language (Dlurak) feat(language): add code v (Dlurak) Jan 29, 2024
Copy link
Member

@Miodec Miodec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Miodec Miodec merged commit b402230 into monkeytypegame:master Jan 29, 2024
8 checks passed
@Miodec
Copy link
Member

Miodec commented Jan 29, 2024

Are there any problems left? This PR still has the "waiting for an update" label

Yeah sorry, that label relies on me manually toggling it on and off

@Dlurak
Copy link
Contributor Author

Dlurak commented Jan 29, 2024

Yeah sorry, that label relies on me manually toggling it on and off

Oh, no problem :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assets Languages, themes, layouts, etc. frontend User interface or web stuff waiting for update Pull requests or issues that require changes/comments before continuing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants