Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker-compose): use the user "node" for the frontend container (dirk-hub) #4963

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Conversation

allergicapple
Copy link
Contributor

@allergicapple allergicapple commented Jan 24, 2024

Description

add user: node to the docker-compose.yaml so docker uses that user instead of the root user when bringing up the container, this makes npm have appropriate rights

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language or a theme?
    • If is a language, did you edit _list.json, _groups.json and add languages.json?
    • If is a theme, did you add the theme.css?
      • Also please add a screenshot of the theme, it would be extra awesome if you do so!
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username inside parentheses at the end of the PR title

…rights problems when starting with `docker-compose up` as it otherwiese would use the "root" user
@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label Jan 24, 2024
@allergicapple allergicapple changed the title fix(docker-compose): use the user "node" for the frontend container (dirk-github) fix(docker-compose): use the user "node" for the frontend container (dirk-hub) Jan 24, 2024
@Miodec Miodec merged commit 4fb519d into monkeytypegame:master Jan 29, 2024
14 checks passed
@Miodec
Copy link
Member

Miodec commented Jan 29, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend User interface or web stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants