Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(language): add english medical (aarnav593) #5108

Merged
merged 29 commits into from
Feb 26, 2024

Conversation

aarnav593
Copy link
Contributor

@aarnav593 aarnav593 commented Feb 22, 2024

Description

I opened an old pull request about 2 months ago, and it was requested that I add 800 words to the existing 200. However, 1000 words, in my opinion, is too many for a wordset of this nature to be effective. There are around 600 in this set, and the addition of 400 more would dilute its effectiveness. Therefore, I am rerequesting its addition to the project.

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language or a theme?
    • If is a language, did you edit _list.json, _groups.json and add languages.json?
    • If is a theme, did you add the theme.css?
      • Also please add a screenshot of the theme, it would be extra awesome if you do so!
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username inside parentheses at the end of the PR title

Closes #

@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels Feb 22, 2024
@Miodec Miodec changed the title feat(languages): add medical terms again (aarnav593) feat(language): add english medical (aarnav593) Feb 26, 2024
@Miodec Miodec merged commit 002770e into monkeytypegame:master Feb 26, 2024
7 checks passed
@aarnav593
Copy link
Contributor Author

@Miodec Would you be okay with acknowledging that I spent 4 hours working on this project (and the quotes I added too) for my community service hour requirement at my school (I asked and open-source projects count)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assets Languages, themes, layouts, etc. frontend User interface or web stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants