-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(language): add english medical (aarnav593) #5108
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added medicine as a language
200 words
fixed naming error
tried creating pull request, returned an error. fixed errors.
saving work
added nearly 500 medical words
fixed a few duplicates
fixed some more duplicates
fixed typo
fixed duplicates again; added two new words (cerebellum and brain stem)
more to come
keeping em coming
monkeytypegeorge
added
frontend
User interface or web stuff
assets
Languages, themes, layouts, etc.
labels
Feb 22, 2024
Miodec
changed the title
feat(languages): add medical terms again (aarnav593)
feat(language): add english medical (aarnav593)
Feb 26, 2024
@Miodec Would you be okay with acknowledging that I spent 4 hours working on this project (and the quotes I added too) for my community service hour requirement at my school (I asked and open-source projects count) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I opened an old pull request about 2 months ago, and it was requested that I add 800 words to the existing 200. However, 1000 words, in my opinion, is too many for a wordset of this nature to be effective. There are around 600 in this set, and the addition of 400 more would dilute its effectiveness. Therefore, I am rerequesting its addition to the project.
Checks
_list.json
,_groups.json
and addlanguages.json
?Closes #