Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Trigger hide() function on any key press (Bretis2019) #5148

Closed
wants to merge 1 commit into from
Closed

Conversation

Bretis2019
Copy link
Contributor

Description

This PR modifies the keydown event handler to trigger the hide() function on the alerts panel for any key press, ensuring that tests can't be started with it still open.

Checks

Closes #5142

@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label Feb 27, 2024
@Miodec Miodec closed this in 5147e75 Feb 28, 2024
@Miodec
Copy link
Member

Miodec commented Feb 28, 2024

This approach would only fix one popup - it was actually an issue in all popups. Fixed it in my commit. Thank you though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend User interface or web stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

You can start a test while still on the alerts panel
3 participants