Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(message): better error message #5244

Merged
merged 7 commits into from
Mar 23, 2024
Merged

chore(message): better error message #5244

merged 7 commits into from
Mar 23, 2024

Conversation

Estifanos12
Copy link
Contributor

Screenshot (170)

Modify the "Firebase Error : (auth/email-already-in-use)" notification message for better clarity and intuitiveness.

@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label Mar 22, 2024
@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/8392637678

@Estifanos12 Estifanos12 changed the title fix(message):create user email already exists message fix:create user email already exists message Mar 22, 2024
@Estifanos12 Estifanos12 changed the title fix:create user email already exists message fix :create user email already exists message Mar 22, 2024
@Estifanos12 Estifanos12 changed the title fix :create user email already exists message fix: create user email already exists message Mar 22, 2024
@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/8392819078

@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/8392872805

@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/8392941450

@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/8393260565

@Estifanos12 Estifanos12 changed the title fix: create user email already exists message fix(message): create user email already exists message Mar 23, 2024
Miodec
Miodec reviewed Mar 23, 2024
View reviewed changes
frontend/src/ts/controllers/account-controller.ts Outdated
if (e instanceof Error) {
if ("code" in e && e.code === "auth/email-already-in-use") {
message = Misc.createErrorMessage(
{ message: "Email already exists" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would update this to Email already in use

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have already updated

@Estifanos12 Estifanos12 changed the title fix(message): create user email already exists message chore(message): better error message Mar 23, 2024
@Miodec Miodec merged commit abbed32 into monkeytypegame:master Mar 23, 2024
8 checks passed
@Miodec
Copy link
Member

Miodec commented Mar 23, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Miodec Miodec Miodec left review comments

Assignees
No one assigned
Labels
frontend User interface or web stuff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Estifanos12 @monkeytypegeorge @Miodec