Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(languages): Add Serbian 10k option #5603

Merged
merged 6 commits into from
Jul 15, 2024
Merged

Conversation

Fooftilly
Copy link
Contributor

Description

I've added a list of 10k words for Serbian, both in Latin and Cyrillic variants.

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language or a theme?
    • If is a language, did you edit _list.json, _groups.json and add languages.json?
    • If is a theme, did you add the theme.css?
      • Also please add a screenshot of the theme, it would be extra awesome if you do so!
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username inside parentheses at the end of the PR title

@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels Jul 10, 2024
@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/9877363902

@Fooftilly
Copy link
Contributor Author

I have no idea what I should do about failed check. Please advise.

@fehmer
Copy link
Member

fehmer commented Jul 10, 2024

Error: Name is not serbian_10k the name property in the json file needs to match the file name.

@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/9892521471

@Fooftilly Fooftilly requested a review from johnhamndon July 14, 2024 18:50
@Fooftilly
Copy link
Contributor Author

Updated the names in the new language files. Didn't notice that there is also the language name inside the json files, because I copied and modified original 200 word versions.

@Miodec Miodec merged commit b243d14 into monkeytypegame:master Jul 15, 2024
7 checks passed
@Miodec
Copy link
Member

Miodec commented Jul 15, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assets Languages, themes, layouts, etc. frontend User interface or web stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants