refactor(build): Optimized Dockerfiles (@ilolm) #5955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Reduced layers amount. 2. Optimized. 3. Reduced image size by adding `--no-cache` option to `apk`. 4. Added `apk update --no-cache`, to always have the latest version of wget.
Reduced layers amount.
ilolm
changed the title
fehmer
requested changes
Oct 8, 2024
There was a problem hiding this comment.
Hi,
i'm using docker version 27.3.1 and both files are failing to build. Which version of docker are you using?
Frontend:
Dockerfile:5
--------------------
3 |
4 | #ENV
5 | >>> ENV ["BACKEND_URL=###MONKEYTYPE_BACKENDURL###", "RECAPTCHA_SITE_KEY=###RECAPTCHA_SITE_KEY###"]
6 |
7 | #COPY
--------------------
ERROR: failed to solve: failed to process "[\"BACKEND_URL": unexpected end of statement while looking for matching double-quote
Backend:
Dockerfile:9
--------------------
8 | #gimme pnpm + build
9 | >>> RUN npm i -g pnpm && \
10 | >>> pnpm i --frozen-lockfile && \
11 | >>> npm run build
12 |
--------------------
ERROR: failed to solve: process "/bin/sh -c npm i -g pnpm && pnpm i --frozen-lockfile && npm run build" did not complete successfully: exit code: 1
github-actions
bot
added
waiting for update
|
This should work now, everything compiles as expected on me. |
|
Backend image reduction is 3MB and one less layer, frontend size/layers is not reduced. |
fehmer
approved these changes
Oct 9, 2024
|
Thanks guys |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Optimized frontend Dockerfile and backend Dockerfile. Reduced layers amount, reduce size of the image.Closes
Optimizes the output docker image and it's size.