-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(input): add 'code unindent on backspace' for code languages (@notTamion) #5991
Conversation
This PR is stale. Please trigger a re-run of the PR check action. |
Not sure i like this change, I've never used a code editor that does what you described. |
Hmm i mostly use Jetbrains Ides (i assume you use vsc then?) I can add a setting to change this then |
183fc81
to
33ead75
Compare
I would change the setting to "code unindent on backspace" and have the settings be on or off (so, a boolean). The setting description could also use some work so that its easier to understand. The default value should be off. |
a6e1547
to
d6d3ce7
Compare
fixed |
Now I can't get it to trigger at all, with freedom or without, with correct previous line or with an error. Am i doing something wrong? |
Do you have a code language selected? |
Oh yeah, my bad, seems to be working correctly. |
Woops. just noticed i didn‘t pull your changes to the message. could you push that commit again or tell me what the new message was so i can change it |
Thats why you generally wanna avoid force pushing ;) |
Thanks |
yeah i usually prefer rebasing over merging but i sometimes forget to pull the feature branch |
When using a code language that has tab characters as indentation and you backspace into the indentation, the entire indentation will now be deleted and you will be set back to the end of the previous line. This is how all Jetbrains ides and also a lot of other ides do it. We could add a config option for this if someone wants one (i wasn't really able to come up with a good name for one).