Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impr(layouts): add basic support for thumb alpha keys (@zigotica) #6023

Merged

Conversation

zigotica
Copy link
Contributor

@zigotica zigotica commented Nov 9, 2024

Description

ROW 5 in alternate keymaps allow for alphas in thumb keys.

  • These keymaps MUST include two keys in row 5, an alpha and a space, or a space and an alpha.
  • Alpha key is rendered with the regular alpha size.
  • Layout name is automatically added in the space key.
  • Added keymaps using alphas in thumbs: anishtro, BEAKL_Zi, MALTRON, PRSTEN and RSTHD

Checks

  • Made sure all physical layouts work for alternate and classic keymaps. Attaching images for all of them in the PR.
alice alpha left alice alpha right alice classic matrix alpha left matrix alpha right matrix classic split-matrix alpha left split-matrix alpha right split-matrix classic split alpha left split alpha right split classic staggered alpha left staggered alpha right staggered classic steno-split steno
  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language or a theme?
    • If is a language, did you edit _list.json, _groups.json and add languages.json?
    • If is a theme, did you add the theme.css?
      • Also please add a screenshot of the theme, it would be extra awesome if you do so!
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.

Closes #2291

@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels Nov 9, 2024
@Miodec
Copy link
Member

Miodec commented Nov 14, 2024

Please move the layouts to the bottom of the list file.

@Miodec
Copy link
Member

Miodec commented Nov 14, 2024

Other than those two I think its all good.

@zigotica
Copy link
Contributor Author

Please move the layouts to the bottom of the list file.

moved

@Miodec Miodec changed the title feat: alphas in thumbs (@zigotica) impr(layouts): add basic support for thumb alpha keys (@zigotica) Nov 18, 2024
@Miodec Miodec merged commit 50639fa into monkeytypegame:master Nov 18, 2024
15 checks passed
@Miodec
Copy link
Member

Miodec commented Nov 18, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assets Languages, themes, layouts, etc. frontend User interface or web stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants