Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(language): remove catalan opening punctuation (@Perseus333) #6035

Merged
merged 8 commits into from
Dec 4, 2024
Merged

fix(language): remove catalan opening punctuation (@Perseus333) #6035

merged 8 commits into from
Dec 4, 2024

Conversation

Perseus333
Copy link
Contributor

@Perseus333 Perseus333 commented Nov 13, 2024 •
edited
Loading

Description

Previously, Spanish exclusive punctuation was included in the Catalan language. In Catalan "¿" and "¡" don't exist. I just made it so that it adds the "¿" and "¡" if the current language is set to spanish.

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language or a theme?
    • If is a language, did you edit _list.json, _groups.json and add languages.json?
    • If is a theme, did you add the theme.css?
      • Also please add a screenshot of the theme, it would be extra awesome if you do so!
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • [ x Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.

Closes #

@Perseus333
Fixed catalan punctuation
f309c10 
Previously, Spanish exclusive punctuation was included in the Catalan language. In Catalan "¿" and "¡" doesn't exist.
@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label Nov 13, 2024
Miodec
Miodec previously approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@Miodec Miodec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Miodec Miodec added the waiting for update Pull requests or issues that require changes/comments before continuing label Nov 14, 2024
@github-actions github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Nov 19, 2024
@Miodec Miodec added the waiting for update Pull requests or issues that require changes/comments before continuing label Nov 21, 2024
@github-actions github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Nov 23, 2024
Miodec
Miodec approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@Miodec Miodec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Miodec Miodec changed the title fix(language): Catalan opening punctuation removed (@Perseus333) fix(language): remove catalan opening punctuation (@Perseus333) Dec 4, 2024
@Miodec Miodec merged commit 7aceed8 into monkeytypegame:master Dec 4, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Miodec Miodec Miodec approved these changes

Assignees
No one assigned
Labels
frontend User interface or web stuff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Perseus333 @Miodec @monkeytypegeorge