Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impr(quotes): add english quotes (@rmenai) #6144

Merged
merged 5 commits into from
Jan 6, 2025
Merged

impr(quotes): add english quotes (@rmenai) #6144

merged 5 commits into from
Jan 6, 2025

Conversation

rmenai
Copy link
Contributor

@rmenai rmenai commented Dec 31, 2024

Description

Added several quotes from DanMachi

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language or a theme?
    • If is a language, did you edit _list.json, _groups.json and add languages.json?
    • If is a theme, did you add the theme.css?
      • Also please add a screenshot of the theme, it would be extra awesome if you do so!
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.

Closes #

@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels Dec 31, 2024
@rmenai rmenai changed the title impr(quotes): add English quotes from DanMachi impr(quotes): add english quotes (@rmenai) Dec 31, 2024
Miodec
Miodec requested changes Jan 6, 2025
View reviewed changes
Copy link
Member

@Miodec Miodec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please replace all ’ with '.

frontend/static/quotes/english.json Outdated Show resolved Hide resolved
@Miodec Miodec added the waiting for update Pull requests or issues that require changes/comments before continuing label Jan 6, 2025
@github-actions github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Jan 6, 2025
@rmenai
Copy link
Contributor Author

rmenai commented Jan 6, 2025

Ok I fixed the single quotes

@Miodec
Copy link
Member

Miodec commented Jan 6, 2025 •
edited
Loading

Please merge in master aswell (there are merge conflicts).

@Miodec Miodec merged commit b490056 into monkeytypegame:master Jan 6, 2025
11 checks passed
@Miodec
Copy link
Member

Miodec commented Jan 6, 2025

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Miodec Miodec Miodec requested changes

Assignees
No one assigned
Labels
assets Languages, themes, layouts, etc. frontend User interface or web stuff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rmenai @Miodec @monkeytypegeorge