Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ARM64 support on LLVM builds #1824

Merged
merged 3 commits into from
Feb 3, 2024
Merged

Enable ARM64 support on LLVM builds #1824

merged 3 commits into from
Feb 3, 2024

Conversation

konistehrad
Copy link
Contributor

@konistehrad konistehrad commented Feb 2, 2024

As suggested by @tritao in #1708 this PR adds support for building LLVM for ARM64 hosts, and adds ARM64 decompilation libs to the linkage.

@konistehrad
Copy link
Contributor Author

@dotnet-policy-service agree

@konistehrad
Copy link
Contributor Author

Tests are failing as the pulled LLVM will need to be rebuilt with DLLVM_TARGETS_TO_BUILD="X86;AArch64"

@tritao
Copy link
Collaborator

tritao commented Feb 2, 2024

Tests are failing as the pulled LLVM will need to be rebuilt with DLLVM_TARGETS_TO_BUILD="X86;AArch64"

Spawned some LLVM builds:

https://github.com/mono/CppSharp/actions/runs/7760243198
https://github.com/mono/CppSharp/actions/runs/7760239936

@konistehrad
Copy link
Contributor Author

Will I need to do anything special to point to these artifacts?

@tritao
Copy link
Collaborator

tritao commented Feb 2, 2024

Will I need to do anything special to point to these artifacts?

Nope, after it finishes building, I'll need to replace the current builds on the releases page with these new ones. After that, the builds for this PR should hopefully progress.

@konistehrad
Copy link
Contributor Author

Great. Thanks again for your assistance on this!

@tritao
Copy link
Collaborator

tritao commented Feb 2, 2024

Can you update the PR with the new ARM64 CI builds: https://github.com/mono/CppSharp/blob/main/.github/workflows/main.yml#L12

@konistehrad
Copy link
Contributor Author

Done!

@tritao
Copy link
Collaborator

tritao commented Feb 2, 2024

My bad, those are failing of course, I thought you already added the new ARM64 parser bindings, but this PR is specifically for the LLVM support. 🤦

So feel free to remove that last commit and we can this one merged.

@konistehrad
Copy link
Contributor Author

konistehrad commented Feb 2, 2024

OK looks like the rest of the errors are predicated on updated bindings. Working on it now. EDIT: let me see if I can gen the bindings quick. I've got Mac headers, I'll collect Linux momentarily.

@konistehrad
Copy link
Contributor Author

Nah you were right, this patch is too big for this PR. Gonna make a dependent branch and open another.

@konistehrad konistehrad mentioned this pull request Feb 3, 2024
@tritao tritao merged commit 1d1b21f into mono:main Feb 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants