Rename IsRunning to IsAnimationEnabled on SKAnimatedSurfaceView

[bijington]

Description of Change

This PR renames the IsRunning property to IsAnimationEnabled to hopefully provide a more meaningful name to the consumer.

Bugs Fixed

• Related to issue #

API Changes

Changed:

• bool SKAnimatedSurfaceView.IsRunning => bool SKAnimatedSurfaceView.IsAnimationEnabled

Behavioral Changes

Changed the default binding mode for the above property from BindingMode.TwoWay to BindingMode.OneWay. The old way caused an issue in testing plus the property is only intended to change whether the control is animating and therefore does not need to update the source.

PR Checklist

• Has tests (if omitted, state reason in description) - I haven't work out how to test this part yet
• Has samples (if omitted, state reason in description)
• Rebased on top of main at time of PR
• Changes adhere to coding standard
• Updated documentation

[mattleibow]

Thanks for this and the great discussion!

[mattleibow]

I see the build is failing for the forms sample app. One last holdout for IsRunning.

[bijington]

I see the build is failing for the forms sample app. One last holdout for IsRunning.

Doh! I didn't check the Forms part! I'll try and sort that.

For unit tests I wanted to validate that the starting and stopping moved the animation progress but I couldn't get it to actually start. I'll try and get that done too

[bijington]

@mattleibow hopefully this push will fix the build. I have failed getting a unit test in though. I wanted check that IsAnimationEnabled prevented any progress updates but by calling CallUpdate as the other tests do, that part doesn't rely on checks against IsAnimationEnabled I think to trigger it otherwise I would need a mock Dispatcher unless you have any ideas?

[mattleibow]

I believe I broke it at some point. I'll try figure it out.

[mattleibow]

I believe when I added events I added them in the wrong order: #126