Rename IsCompleted to IsRunning #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also swapped to a BindingMode.OneWayToSource to allow this to provide values out to the VM or other controls in bindings with it not intended to control the running of the animation itself
mattleibow
approved these changes
Jul 7, 2022
|
I am reverting this because I am noticing an ambiguous state. If I have a lottie/confetti view that is disabled, the IsRunning will still be true (based on implementation logic) because it was originally designed to represent whether the animation is complete or not. For example, if you have a lottie that is 2 seconds long and you are at 1s - you are not complete and you are running. If you are to disable the view at this point, you are still running and still not complete. Using the IsRunning terminology, you would sort of expect it to be false because it is not moving. However, with the IsComplete terminology, this is not expected. The first PR with IsAnimationEnabled is still a much better term. |
mattleibow
added a commit
that referenced
this pull request
Jul 13, 2022
This reverts commit ce6c5c0.
mattleibow
added a commit
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Renamed the
IsCompleteproperty toIsRunning.Bugs Fixed
API Changes
Behavioral Changes
Inversion of the value to match the change of name.
The
IsRunningproperty now has a default binding mode ofBindingMode.OneWayToSourceas it is used to bring information out of the control and drive values in.PR Checklist