Allow for a slightly delayed theme registration #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
In some cases, the view can be constructed during the app creating, and as a result the app is not actually ready yet. This occurs when passing the page as a constructor argument - the page is created before the app, and thus the view is created before the app and when it tries to register with the app it skips.
This PR is going to wait until there is a window and try again. At that point there should be an app and a window. There is the case where the app may get a window before the app - if the window is a constructor parameter - but this is not really useful in maui as apps may have multiple windows.
Bugs Fixed