Multitarget Views.WPF

[TysonMN]

Description of Change

SkiaSharp.View.WPF now targets .NET Core 3.0 in addition to .NET Framework 4.5.1.

Bugs Fixed

Related to issue #1029, which is about getting both SkiaSharp.View.WPF as well as SkiaSharp.View.WindowsForms to target .Net Core.

API Changes

None

PR Checklist

• Has tests (if omitted, state reason in description)
• Rebased on top of master at time of PR
• NA
• Changes adhere to coding standard
• Updated documentation

[mattleibow]

We can also update the nuspecs with the new netcoreapp3.0:
https://github.com/mono/SkiaSharp/blob/master/nuget/SkiaSharp.Views.Desktop.Common.nuspec#L39

And:
https://github.com/mono/SkiaSharp/blob/master/nuget/SkiaSharp.Views.WPF.nuspec#L38

Just note, the nuspecs are pseudo-nuspec and are manipulated in the build. That is why they are a bit different.

[TysonMN]

What should the platform be for
https://github.com/mono/SkiaSharp/blob/master/nuget/SkiaSharp.Views.WPF.nuspec#L38
?

[mattleibow]

The platform that builds it. It looks to build on all the platforms, so leave it out.

[TysonMN]

We can also update the nuspecs with the new netcoreapp3.0:
https://github.com/mono/SkiaSharp/blob/master/nuget/SkiaSharp.Views.Desktop.Common.nuspec#L39

And:
https://github.com/mono/SkiaSharp/blob/master/nuget/SkiaSharp.Views.WPF.nuspec#L38

Done :)

[mattleibow]

Thanks for the PR! Merged!

[TysonMN]

My pleasure :)

Is there a NuGet package (possibly a pre-release) with these changes?

I would test it by adding it to a project we are developing at work.

[mattleibow]

We can! Just noticed that this branch failed to build because DevOps got disconnected from all its agents... Rebuilding and then I'll let you know when you can get your hands on the build.

I did start a build on our public CI:
https://dev.azure.com/xamarin/public/_build/results?buildId=11744&view=results

That should work for testing, but I am also going to push out the PR build to the preview feed:

https://aka.ms/skiasharp-eap/index.json

The reason for this is that CI builds both the preview and the stable packages to make sure everything is working. Then when I release I first push the preview packages for a few weeks, and then go stable - no need to rebuild. But, sometimes you may be tempted to select the stable packages from the CI server - and then it gets cached... I can control what gets to the preview feed.

[mattleibow]

Hehe, seems my certificates to build the samples expired today... I'm going to have to upload them to CI, but I need to get a sleep action going here. When I wake up in a few hours, I'll rebuild with the v1.68.2 and push that after merging the VS2019 build to master.