Remove OpenTK references from View.WPF #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
I'm a cowboy 🤠 just merging PRs before the build even runs! |
mattleibow
added a commit
that referenced
this pull request
Dec 22, 2019
* Upgraded a good few things - multitargeting for netstandard1.3, netstandard2.0, netcoreapp3.0 and net45 - iOS, tvOS, macOS, watchOS now builds on non-macOS (not embedded binaries) - removed empty assembly infos - using Directory.Build.* to clean up a few things - improved the msbuild tasks to properly skip * Add the targets file to the nuget * Let all the tests run before failing the build * Pack and validate in one go * Update the samples to use the new projects * Use VS 2017 for native builds for now * Update Dockerfiles * removed references from Views.WPF to OpenTK #1029 (#1078) * Install the type redirector * Update depot_tools * Don't do any signing for macOS Co-authored-by: Tyson Williams <34664007+bender2k14@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
In addition to having no compile-time dependency (and as pointed out in #1029 (comment)), the nuspec file for View.WPF does not reference any OpenTK packages, so Views.WPF shouldn't need to reference these packages either.
Bugs Fixed
Related to issue #1029. This change removes two warnings when targeting .NET Core in View.WPF.
API Changes
None.
Behavioral Changes
None.
PR Checklist