Add Alpine Native Libraries #1339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
mattleibow
commented
Jun 17, 2020
| @@ -61,7 +61,7 @@ void GnNinja(DirectoryPath outDir, string target, string skiaArgs) | |||
|
|
|||
| // build native skia | |||
| RunProcess(NINJA_EXE, new ProcessSettings { | |||
| Arguments = $"{target} -C out/{outDir}", | |||
| Arguments = $"-C out/{outDir} {target}", | |||
There was a problem hiding this comment.
Seems some version of ninja don't like this order.
mattleibow
commented
Jun 27, 2020
Comment on lines
+1
to
+8
| FROM amd64/alpine:3.9 | ||
|
|
||
| RUN apk add --no-cache bash curl ca-certificates python git build-base ninja fontconfig-dev | ||
| RUN apk add --no-cache samurai --repository http://dl-cdn.alpinelinux.org/alpine/edge/main | ||
| RUN apk add --no-cache mono clang gn --repository http://dl-cdn.alpinelinux.org/alpine/edge/testing | ||
| RUN cert-sync /etc/ssl/certs/ca-certificates.crt | ||
|
|
||
| WORKDIR /work |
There was a problem hiding this comment.
This is the Docker file to run on.
Comment on lines
+252
to
+259
| - template: azure-templates-bootstrapper.yml # Build Native Linux [Alpine] (Linux) | ||
| parameters: | ||
| name: native_linux_alpine_linux | ||
| displayName: Build Native Linux [Alpine] (Linux) | ||
| vmImage: $(VM_IMAGE_LINUX) | ||
| docker: scripts/Docker/alpine/amd64 | ||
| target: externals-linux | ||
| additionalArgs: --buildarch=x64 --gn=gn --ninja=ninja --variant=alpine |
There was a problem hiding this comment.
Add an entry to the CI build
Comment on lines
+335
to
+336
| - native_linux_alpinenodependencies_linux | ||
| - native_linux_alpine_linux |
There was a problem hiding this comment.
Include it in the managed build/packaging.
| @@ -45,6 +45,7 @@ Please visit https://go.microsoft.com/fwlink/?linkid=868517 to view the release | |||
|
|
|||
| <!-- libSkiaSharp.dll and other native files --> | |||
| <file platform="linux" src="runtimes/linux-x64/native/libSkiaSharp.so" /> | |||
| <file platform="linux" src="runtimes/linux-musl-x64/native/libSkiaSharp.so" /> | |||
There was a problem hiding this comment.
Add the asset to the NuGet package
Comment on lines
+33
to
+34
| <None Include="..\..\output\native\alpine\x64\libSkiaSharp.so" Link="nuget\runtimes\linux-musl-x64\native\libSkiaSharp.so" | ||
| Condition=" Exists('..\..\output\native\alpine\x64\libSkiaSharp.so') or '$(IsLinux)' == 'true' " /> |
There was a problem hiding this comment.
Add the asset to the project.
ScrubN
added a commit
to ScrubN/TwitchDownloader
that referenced
this pull request
Aug 30, 2023
According to mono/SkiaSharp#1339, the alpine binary should be included in the standard NativeAssets.Linux package. Needs testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Adding a build for Alpine linux.
Builds on Alpine 3.9, tested all the way back to Alpine 3.7.
Bugs Fixed
API Changes
None.
Behavioral Changes
The *.NativeAssets.Linux NuGet packages will now have an Alpine linux binary.
PR Checklist