[netcore] remove 2 extra members from System.Object #20535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monojenkins
requested review from
BrzVlad,
lambdageek,
SamMonoRT and
vargaz
as code owners
monojenkins
force-pushed
the
sync-pr-44081-from-runtime
branch
from
0c34b4d
to
ca9df80
Compare
lambdageek
approved these changes
Nov 2, 2020
lambdageek
changed the title
1. move `GetRawData` to an extension method in RuntimeHelpers and fixup the intrinsics 2. replace `Object.CloneInternal` by `MarshalAsAttribute.CloneInternal` at its one use site 3. re-enable System.Reflection.Tests.TypeInfoTests.FindMembers and fix mono#15029
monojenkins
force-pushed
the
sync-pr-44081-from-runtime
branch
from
ca9df80
to
4d61286
Compare
CoffeeFlux
approved these changes
Nov 2, 2020
|
@monojenkins build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!! This PR is a copy of dotnet/runtime#44081, please do not edit or review it in this repo !!
Do not automatically approve this PR:
* Consider how the changes affect configurations in this repo,
* Check effects on files that are not mirrored,
* Identify test cases that may be needed in this repo.
!! Merge the PR only after the original PR is merged !!
1. move
GetRawDatato an extension method in RuntimeHelpers and fixup the intrinsics2. replace
Object.CloneInternalbyMarshalAsAttribute.CloneInternalat its one use site3. re-enable System.Reflection.Tests.TypeInfoTests.FindMembers and fix #15029