Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lock screen rotation when scanner is shown #7

Merged
merged 5 commits into from
Apr 27, 2021
Merged

Lock screen rotation when scanner is shown #7

merged 5 commits into from
Apr 27, 2021

Conversation

DavideBicego
Copy link
Contributor

Resolve #6

@DavideBicego
Copy link
Contributor Author

It is probably better to have the possibility to modify this behaviour from Flutter side but I don't really have the knowledge necessary to do that on Swift and Kotlin...

mono0926
mono0926 requested changes Apr 23, 2021
View reviewed changes
Copy link
Owner

@mono0926 mono0926 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DavideBicego

Thanks, could you add the change to CHANGELOG at ## 4.1.0, please.

@DavideBicego DavideBicego requested a review from mono0926 April 26, 2021 09:50
mono0926
mono0926 approved these changes Apr 27, 2021
View reviewed changes
Copy link
Owner

@mono0926 mono0926 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

██╗      ██████╗ ████████╗███╗   ███╗
██║     ██╔════╝ ╚══██╔══╝████╗ ████║
██║     ██║  ███╗   ██║   ██╔████╔██║
██║     ██║   ██║   ██║   ██║╚██╔╝██║
███████╗╚██████╔╝   ██║   ██║ ╚═╝ ██║
╚══════╝ ╚═════╝    ╚═╝   ╚═╝     ╚═╝

@mono0926 mono0926 merged commit e602516 into mono0926:main Apr 27, 2021
@mono0926 mono0926 mentioned this pull request Jun 23, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mono0926 mono0926 mono0926 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Lock screen rotation when scanner is showing
2 participants
@DavideBicego @mono0926