Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider using css custom properties across style sheets #172

Closed
ngwese opened this issue Oct 22, 2019 · 4 comments
Closed

consider using css custom properties across style sheets #172

ngwese opened this issue Oct 22, 2019 · 4 comments

Comments

@ngwese
Copy link
Member

ngwese commented Oct 22, 2019

There are many places in the existing CSS code where color values are duplicated. It would be worth collecting these up as CSS properties.
https://developer.mozilla.org/en-US/docs/Web/CSS/Using_CSS_custom_properties

@ryanlaws
Copy link
Contributor

Hopefully this is a stupid question - do we need IE support? Because per the MDN link, it looks like CSS custom properties are not a thing in IE. I don't expect this to really be an issue for the norns user base but I figured it better to ask than assume 😉

@ngwese
Copy link
Member Author

ngwese commented Nov 3, 2019

I don't think we need IE support... It seems safe to assume modern Windows with Edge, Firefox, or Chrome.

@dansimco
Copy link
Contributor

Centralised css colour variables in #215 . I tried to match existing colours as close as possible while cleaning up a bit of fragmentation so it it was low-contrast before, it still is in my PR.

@ngwese
Copy link
Member Author

ngwese commented Oct 23, 2021

closing this out thanks to @dansimco‘s work on a proper dark mode

@ngwese ngwese closed this as completed Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants