-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consider using css custom properties across style sheets #172
Comments
Hopefully this is a stupid question - do we need IE support? Because per the MDN link, it looks like CSS custom properties are not a thing in IE. I don't expect this to really be an issue for the norns user base but I figured it better to ask than assume 😉 |
I don't think we need IE support... It seems safe to assume modern Windows with Edge, Firefox, or Chrome. |
Centralised css colour variables in #215 . I tried to match existing colours as close as possible while cleaning up a bit of fragmentation so it it was low-contrast before, it still is in my PR. |
closing this out thanks to @dansimco‘s work on a proper dark mode |
There are many places in the existing CSS code where color values are duplicated. It would be worth collecting these up as CSS properties.
https://developer.mozilla.org/en-US/docs/Web/CSS/Using_CSS_custom_properties
The text was updated successfully, but these errors were encountered: