Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

super low contrast for help menu text in chrome #174

Closed
ngwese opened this issue Oct 30, 2019 · 2 comments · Fixed by #180
Closed

super low contrast for help menu text in chrome #174

ngwese opened this issue Oct 30, 2019 · 2 comments · Fixed by #180
Labels
bug good first issue Good for newcomers

Comments

@ngwese
Copy link
Member

ngwese commented Oct 30, 2019

There seems to be an accidental CSS regression or a change in behavior in recent versions of Chrome. The help menu renders in a much more faint gray in Chrome 78 (macOS) and Firefox 70 vs Firefox 69:

Firefox 69 / previous:
image

Firefox 70 / Chrome 78
image
@ngwese ngwese added bug good first issue Good for newcomers labels Oct 30, 2019
@ryanlaws
Copy link
Contributor

ryanlaws commented Oct 30, 2019 •
edited
Loading

#172 could probably help with this.

Using a contrast checker in tests may be helpful. Something like this maybe: https://www.npmjs.com/package/color-contrast-checker

@ngwese
Copy link
Member Author

ngwese commented Jan 27, 2020

...something weird is going on. As of the most recent release the menu background is now appears semi-transparent.

@nattog nattog mentioned this issue Jan 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix - low contrast on help menu nattog/maiden
2 participants
@ngwese @ryanlaws