-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEL.X / DEL.R ops #164
Merged
Merged
DEL.X / DEL.R ops #164
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
5296d2e
added RAT
ryan-hodgman1 90cea46
fixed RAT error in op.c
ryan-hodgman1 1f47cc7
updated xdel op
ryan-hodgman1 71a9616
Merge remote-tracking branch 'upstream/master'
ryan-hodgman1 e31d306
xdel op update and common delay code function
ryan-hodgman1 b50f2d8
updated variable names, changed xdel op names
ryan-hodgman1 f0bfd37
added info the CHANGELOG.md
ryan-hodgman1 ec7aacf
added DEL.X and DEL.R documentation
ryan-hodgman1 7beff19
added info the CHANGELOG.md
ryan-hodgman1 1fd3574
added check to delay_common_add helper function in delay.c
ryan-hodgman1 4151cdf
updated delay common add function to properly check free delay slots,…
ryan-hodgman1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would add a check here to make sure it doesn't exceed
DELAY_SIZE
- imho it's a good idea to have safety checks in helper functions.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah good catch I can add that in. on the same topic do you think it would be good to move
tele_has_delays
into the helper function as well? the downside is it would get called excess times times byDEL.X
, but the change would make the helper function slightly more robust for other future usage.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'd leave it out - the function has a well defined and logical contract (it adds a delay),
tele_has_delays
is outside of that (and only has meaning to where this function is called from).