require confirm for flash initialization #170
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
on flash_reset detection (checking magic number in
flash_prepare
) blink a light and wait for confirmation by pressing key down. otherwise it times out and doesn't run.Provide links to any related discussion on lines.
How should this be manually tested?
works perfectly well for newly flashed units. we'd need to see the bug-state to trigger this, which isn't known. it's a protection measure at this point.
Any background context you want to provide?
If the related Github issues aren't referenced in your commits, please link to them here.
I have,
CHANGELOG.md
make format
on each commit