Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: manually trigger cvTimer on cv change #183

Merged
merged 2 commits into from
Jul 25, 2019

Conversation

csboling
Copy link
Collaborator

@csboling csboling commented Jul 25, 2019

What does this PR do?

Changes what appears to be a typo manually triggering adcTimer instead of cvTimer in tele_cv, which was causing DACs not to update until the CV timer expires when using CV ops.

Provide links to any related discussion on lines.

https://llllllll.co/t/teletype-timing-issues-cv-edition/24193/9?u=csboling

How should this be manually tested?

Report from testing with an oscilloscope on Lines: "CV state changes have c. 200us of latency + c. 500us of jitter after this update" (down from as much as 6ms)

Any background context you want to provide?

If the related Github issues aren't referenced in your commits, please link to them here.

I have,

  • updated CHANGELOG.md
  • updated the documentation - N/A
  • run make format on each commit - N/A

@csboling csboling changed the title Fix/cv timer manual bugfix: manually trigger cvTimer on cv change Jul 25, 2019
@tehn tehn merged commit 38668ca into monome:master Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants