Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal menu for USB read/write operations #321

Merged
merged 6 commits into from
Jun 2, 2023
Merged

Conversation

Dewb
Copy link
Contributor

@Dewb Dewb commented May 7, 2023

What does this PR do?

Adds a minimal menu for USB operations. This feature design was suggested by @beels as a minimal useful gesture towards his
WIP usb-disk-menu branch.

How should this be manually tested?

Insert a USB stick. You should see a menu with four options. Turn the param knob to highlight an option and press the front button to select it. EXIT will return to live mode without doing anything. WRITE TO USB will copy scenes from flash to the tt00s.txt files. READ FROM USB will copy the contents of the tt00.txt files to flash memory. DO BOTH will perform both a write and then a read, the previous behavior.

Any background context you want to provide?

From Discord discussion, there are a couple motivations here:

  • providing a failsafe to avoid inadvertent usb operations if an inserted USB drive is physically touched in such a way that it retriggers the MSC connection event.
  • making a minimally useful gesture in this direction to reduce the activation energy for continuing to enhance the usb menu in future releases.

If the related Github issues aren't referenced in your commits, please link to them here.

#81

I have,

  • updated CHANGELOG.md and whats_new.md
  • (n/a) updated the documentation
  • (n/a) updated help_mode.c (if applicable)

@Dewb Dewb marked this pull request as draft May 7, 2023 17:49
@Dewb Dewb changed the title Usb minimal menu Minimal menu for USB read/write operations May 7, 2023
@Dewb Dewb marked this pull request as ready for review May 7, 2023 21:06
@Dewb
Copy link
Contributor Author

Dewb commented May 7, 2023

recommend viewing the diff in "hide whitespace" mode.

Copy link
Member

@tehn tehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! this is a huge UI improvement.

code looks good, did not test on hardware.

@scanner-darkly
Copy link
Member

looks good!

@tehn tehn merged commit 1711512 into monome:main Jun 2, 2023
@Dewb Dewb deleted the usb-minimal-menu branch June 5, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants