Resolve several data_roots for svg images when liip_imagine filter is used #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delyriand
approved these changes
Oct 26, 2023
Kiwikoti
force-pushed
the
feature/handle-svg-liip-imagine
branch
from
68c9e3f
to
f4bfcab
Compare
maximehuran
approved these changes
Oct 26, 2023
…liip imagine to check multiple data_roots for svg files
Kiwikoti
force-pushed
the
feature/handle-svg-liip-imagine
branch
from
f4bfcab
to
ab1b9cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
The
apps/sylius/vendor/sylius/sylius/src/Sylius/Bundle/CoreBundle/DependencyInjection/Compiler/LiipImageFiltersPass.phpforces the directory of an svg to be'/media/image/'but in the plugin we are allowing otherdata_root. This makes the svg to not be rendered when using aliip_imaginefilter because the path is wrong.In our case '/media/' so we can have an svg in
/media/gallery/images/.We loop through the existing
data_rootsand if it's an svg and the file exists we resolve the path.Features
Enregistrement.de.l.ecran.2023-10-26.a.15.06.04.mov
Fix preview of svg in modal:
