Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update intl library to 0.18.0 #18

Merged
merged 6 commits into from
Aug 1, 2023
Merged

Update intl library to 0.18.0 #18

merged 6 commits into from
Aug 1, 2023

Conversation

enricmacias
Copy link
Collaborator

@enricmacias enricmacias commented Jul 28, 2023 •
edited
Loading

Issue

  • The project was not compiling because of the following error
Because flutter_template_riverpod depends on flutter_localizations from sdk which depends on intl 0.18.0, intl 0.18.0 is required.
  • Other deprecation issues arise during automatic tests. They have also been solved in here.
  • The project was giving building issues with old Flutter versions

Motivation and Context

  • Update the library to the required version and it makes the project to compile
  • Delete some removed lints
  • Solve an issue with the use of window
  • Add a Flutter minimum target

Modified points

  • Change intl library from 0.17 -> 0.18

@enricmacias enricmacias self-assigned this Jul 28, 2023
@enricmacias enricmacias added the bug Something isn't working label Jul 28, 2023
diarmaidlindsay
diarmaidlindsay reviewed Jul 28, 2023
View reviewed changes
analysis_options.yaml
@@ -72,7 +72,6 @@ linter:
- hash_and_equals
- implementation_imports
- iterable_contains_unrelated_type
- invariant_booleans
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw this was deprecated
https://github.com/dart-lang/linter/issues/811#issuecomment-1289550703

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diarmaidlindsay
That is why I am deleting it. What do you mean?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am supporting the deletion by linking to the official documentation 👍

diarmaidlindsay
diarmaidlindsay reviewed Jul 28, 2023
View reviewed changes
analysis_options.yaml
@@ -91,7 +90,6 @@ linter:
- prefer_collection_literals
- prefer_conditional_assignment
- prefer_contains
- prefer_equal_for_default_values
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://dart.dev/tools/linter-rules/prefer_equal_for_default_values

This has also been removed

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diarmaidlindsay Exactly, that is why I am deleting it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep again I was supporting the removal by linking to the docs 👍

diarmaidlindsay
diarmaidlindsay approved these changes Jul 31, 2023
View reviewed changes
Copy link
Collaborator

@diarmaidlindsay diarmaidlindsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I compiled and it ran successfully with the specified Flutter version.

@enricmacias enricmacias merged commit b109724 into master Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diarmaidlindsay diarmaidlindsay diarmaidlindsay approved these changes

Assignees

@enricmacias enricmacias

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enricmacias @diarmaidlindsay