-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package e2e testing #402
Package e2e testing #402
Conversation
@@ -1,5 +1,6 @@ | |||
{ | |||
"$schema": "https://turbo.build/schema.json", | |||
"globalEnv": ["CI"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"test": "turbo run build test --filter=!reactjs-boilerplate", | ||
"test": "turbo run build --filter=create-codes test --filter=create-codes", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only now, no other testing is involved except for the cli program testing.
"@types/node": "18.11.18", | ||
"@types/react": "18.0.27", | ||
"@types/react-dom": "18.0.10", | ||
"@types/testing-library__jest-dom": "5.14.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we do not plan to use jest globally in the future, we will avoid the type error by adding the primary type once.
Looks like the e2e test was a success with CI https://github.com/monstar-lab-oss/reactjs-boilerplate/actions/runs/3987218590/jobs/6836745980 |
Issue #391
What I did
Package the e2e test that is running now.
How to test
If your answer is yes to any of these, please make sure to include it in your PR.