Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MR4: Re-enable lang upgrades after on-sync period (4.5) #133

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

junpataleta
Copy link
Contributor

Part of the 4.5 release process. This will be merged after the on-sync period.

Part of the 4.5 release process. This will be merged after the [on-sync period](http://localhost:3000/general/development/process/release#2-weeks-after).
@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.15%. Comparing base (a2fa45a) to head (afff3ea).

❗ There is a different number of reports uploaded between BASE (a2fa45a) and HEAD (afff3ea). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (a2fa45a) HEAD (afff3ea)
behat_test 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #133      +/-   ##
==========================================
- Coverage   63.84%   57.15%   -6.70%     
==========================================
  Files          47       47              
  Lines        1643     1643              
==========================================
- Hits         1049      939     -110     
- Misses        594      704     +110     
Flag Coverage Δ
behat_bisect_test 40.41% <0.00%> (ø)
behat_test ?
phpunit_bisect_test 34.87% <0.00%> (ø)
phpunit_test 34.93% <0.00%> (ø)
postjobs_test 33.57% <0.00%> (ø)
runner_test 16.25% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mudrd8mz
Copy link
Member

mudrd8mz commented Oct 7, 2024

FYI, Moodle 5.0 language packs are now available - https://download.moodle.org/langpack/5.0

@junpataleta junpataleta merged commit 3114715 into moodlehq:main Oct 10, 2024
10 of 14 checks passed
@junpataleta
Copy link
Contributor Author

Thanks, @mudrd8mz! So, this can now be merged. Self-merging this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants