Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove phpdocsinvalidtag, phpdocsnotrecommendedtag, phpdocsinvalidpathtag #136

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

andrewnicols
Copy link
Contributor

@andrewnicols andrewnicols commented Mar 17, 2024

Replaced with moodlehq/moodle-cs#124

Copy link
Member

@stronk7 stronk7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should consider also removing the config arrays, if they aren't used anymore?

Link: https://github.com/moodlehq/moodle-local_moodlecheck/blob/main/file.php#L1097-L1217

I'm happy either way, your preference.

Ciao :-)

@andrewnicols
Copy link
Contributor Author

Maybe we should consider also removing the config arrays, if they aren't used anymore?

Link: https://github.com/moodlehq/moodle-local_moodlecheck/blob/main/file.php#L1097-L1217

I'm happy either way, your preference.

Ciao :-)

Ah good catch

The validTags are still in use for inline params -- I haven't moved that one yet, but I've removed the rest.
I've also removed some unused fixtures and raised a new issue for other fixtures which should have been removed.

Copy link
Member

@stronk7 stronk7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All ok, landing this before moodlehq/moodle-cs#124 that is near, near, near... thanks!

@stronk7 stronk7 merged commit 5890543 into moodlehq:main Mar 19, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants