Table of contents #60
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a wiki with the settings 'seperate groups' and 'seperate wiki for each group'. Open the wiki, you will get the message that the page has not been created yet. Reload the page and you will receive a db write error. table: ouwikis_subwikis I think the problem is related to two uniqueness restrictions: 1. There must be only one entry for a group and wiki 2. There must be only one entry for a wiki and user (a seperate wiki for every user) In case of group wikis the user field is NULL. When opening the wiki first, an table entry is generated. When opening it the second time, Moodle tries to generate a second entry. But there already is the same combination of wiki and user (NULL) - The user-id is written to every entry in the mentioned table to avoid collisions of wikiid<->NULL - When getting the subwiki, moodle shall not look for user=NULL This may lead to problems in case of seperate wikis for every user
There are two constraints on the table ouwiki_subwikis 1. combination of wikiid and groupid must be unique 2. combination of wikiid and userid must be unique Example: Two subwikis for different groups resulted in wikiid: 1 groupid: 1 userid: NULL wikiid: 1 groupid: 2 userid: NULL On MSSQL this is prohibited by constraint 2 and the creation of the second subwiki resulted in an exception. To fix this the magic number is used as userid or groupid in case they are NULL.
# Conflicts: # entirewiki.php # lang/en/ouwiki.php # locallib.php # styles.css
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes add a numbered table of contents to every wiki page