Use moodle_url to generate links in wiki history page #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In M3.4+, MDL-59388 has changed how the link_arrow_[left|right] functions render URLs. If it's passed a plain url with pre-escaped ampersands in it, these now get double escaped. To remedy this, proper moodle_url objects should be used for handling the printing of urls. This change updates the links used in the wikihistory page to use that API for all its urls. This way the code change is compatible with earlier versions of Moodle as well as 3.4+. There is no functional change for the end user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In M3.4+, MDL-59388 has changed how the link_arrow_[left|right]
functions render URLs. If it's passed a plain url with pre-escaped
ampersands in it, these now get double escaped.
To remedy this, proper moodle_url objects should be used for handling
the printing of urls. This change updates the links used in the
wikihistory page to use that API for all its urls.
This way the code change is compatible with earlier versions of Moodle
as well as 3.4+.
There is no functional change for the end user.