Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add http response to TraktException #138

Merged
merged 1 commit into from
Mar 16, 2021

Conversation

simonc56
Copy link
Contributor

To be able to read the "Retry-After" value of a 429 http error (trakt rate limit exceeded) the rised exception should give access to http response header.
This PR adds the http response to TraktException.

@glensc
Copy link
Contributor

glensc commented Mar 15, 2021

@twolaw rebase, you introduced somebody else commits, likely due forking of the older version of their master branch, see Commits and Files Changed tabs.

@simonc56
Copy link
Contributor Author

simonc56 commented Mar 15, 2021

you introduced somebody else commits

I know, I had to do that for tests to pass successfully.
If i rebase to master the tests will fail.

@moogar0880 should I rebase ? or wait for #137 merge ?

@glensc
Copy link
Contributor

glensc commented Mar 15, 2021

@twolaw I think then you should mark PR as Draft, as it's not ready for merge...

@glensc
Copy link
Contributor

glensc commented Mar 15, 2021

@twolaw you also have not included detail in this PR body that you took commits from elsewhere or that you even rely on some other PR...

@moogar0880
Copy link
Owner

@twolaw I'll wrap up testing on #137 and then we can rebase these changes on that. FWIW the commits you've added here definitely make sense 👍

@moogar0880
Copy link
Owner

@twolaw #137 just landed. you should be good to rebase and we can get these changes out with the 3.0.0 release

Copy link
Owner

@moogar0880 moogar0880 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@twolaw LGTM. I'll get this merged and get the 3.0.0 release out shortly 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants