-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add http response to TraktException #138
Conversation
35c6f6c
to
8ab1c2e
Compare
@twolaw rebase, you introduced somebody else commits, likely due forking of the older version of their master branch, see |
I know, I had to do that for tests to pass successfully. @moogar0880 should I rebase ? or wait for #137 merge ? |
@twolaw I think then you should mark PR as Draft, as it's not ready for merge... |
@twolaw you also have not included detail in this PR body that you took commits from elsewhere or that you even rely on some other PR... |
@twolaw I'll wrap up testing on #137 and then we can rebase these changes on that. FWIW the commits you've added here definitely make sense 👍 |
@twolaw #137 just landed. you should be good to rebase and we can get these changes out with the 3.0.0 release |
8ab1c2e
to
0f60294
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@twolaw LGTM. I'll get this merged and get the 3.0.0 release out shortly 👍
To be able to read the "Retry-After" value of a 429 http error (trakt rate limit exceeded) the rised exception should give access to http response header.
This PR adds the http response to TraktException.