rddepman: bump dockerCLI from 25.0.4 to 26.0.0 #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- On Windows, determine the window to capture using the window title, rather than the active window. Sometimes we can end up with the wrong window being active, even with no human intervention (e.g. in CI). - On Linux, manually walk the window tree to locate the window that is a child of the root window. This ensures that we will capture any window frames correctly. Also, switch to using GraphicsMagick instead of gnome-screenshot, because (at least in CI) we will not be in a full Gnome environment. - Spawn commands as separate arguments rather than a single command line, to better handle things like spaces in file paths. - Add some logging for the script, so that we can troubleshoot any errors in taking screenshots. - Start Rancher Desktop with the test helper, rather than trying to run the command manually. Note that we're not using the mock backend because we need to install extensions. Signed-off-by: Mark Yen <mark.yen@suse.com>
Creating a Kubernetes client requires a valid kubeconfig (so that we can figure out the parameters for it); this means that we need to defer actually doing so until the point where the configuration is ready. The screenshot backend (used to fake the list of services) was incorrectly doing so at the start before actually starting k3s; this lead to things failing on fresh machines. Signed-off-by: Mark Yen <mark.yen@suse.com>
If we capture stderr (and ignore its return value), we can see it in the error that goes thrown when things go wrong. This helps with debugging. Signed-off-by: Mark Yen <mark.yen@suse.com>
This adds a CI job to take screenshots. This avoid issues with having to track down people around release across platforms, and what changes they may have made to their local system. Signed-off-by: Mark Yen <mark.yen@suse.com>
On Windows, for some reason `errors.Is(..., ENOENT)` doesn't work correctly and fails to catch the error. Signed-off-by: Mark Yen <mark.yen@suse.com>
Signed-off-by: Mark Yen <mark.yen@suse.com>
On Windows, it appears that running `rdctl` ended up draining standard input; however, we needed that standard input to iterate over all snapshots so we can delete them. Work around the issue by explicitly redirecting standard input from `/dev/null` so that the original standard input is left alone. Additionally, when deleting all snapshots, check that the snapshots have actually been cleared afterwards. This catches the above problem where we do not delete all snapshots. Signed-off-by: Mark Yen <mark.yen@suse.com>
Signed-off-by: Rancher Desktop Dependency Manager <donotuse@rancherdesktop.io>
mook-as
force-pushed
the
main
branch
9 times, most recently
from
3459556 to
01ece1d
Compare
mook-as
force-pushed
the
main
branch
23 times, most recently
from
91a8f4e to
fc37861
Compare
mook-as
force-pushed
the
main
branch
4 times, most recently
from
b18462a to
ae94390
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.