-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unclear inferred version number #129
Comments
Hi @bergtwvd , I guess you already hit the point as the issue is only about the workspace status, which is DIRTY. If you run |
Hi, I am still puzzled how nyx gets the the name I do a fresh clone of the repository and a git status: In this example there is a main and development branch, but not tags have been set yet. The following files are committed: Where Next I start the container with nyx: And I run the command Looking in the log with debug I see that nyx marks the repo status as dirty, skipping mainline as branch, and it eventually ends up using internal as name: I this how it is supposed to work? |
Hi, that's the expected behavior unless Nyx fails to detect the repo status (CLEAN or DIRTY). Can you please run |
After testing with different scenarios I've hit some cases where the CLEAN/DIRTY is wrong. I'm reopening this issue |
After a quick investigation it turns out there's a bug. I opened #130 for this |
* chode: add debug logs * chore: clean some illegal characters * chore: clean unnecessary import statements * test: bug #130 reproduced (Go tests are supposed to fail) #129 #130 * fix: wrong inferred Git workspace status in Go #130 #129 * test: bug #130 reproduced (Go tests are supposed to fail) #129 #130 * fix: wrong inferred Git workspace status in Go #130 #129 * test: bug #130 reproduced (Go tests are supposed to fail) #129 #130 * test: bug #130 reproduced (Go tests are supposed to fail) #129 #130 * test: bug #130 reproduced (Go tests are supposed to fail) #129 #130 * test: bug #130 reproduced (Go tests are supposed to fail) #129 #130 * fix: wrong inferred Git workspace status in Go #130 #129 * build: enable matrix build for Go integration tests (some Go integration tests may fail) * build: enable matrix build for Go unit tests (some Go integration tests may fail) * test: testing again after introducing the test matrix for Go unit and integration tests
Fix is generally available in release 1.3.3. |
Before we use nyx in anger, we have set up a small test environment.
We use the extended preset and are confused in the inferred version number for both main and development branches. Could you explain how we get to the version numbers?
We also see an odd message in the (attached) debug log for the infer on the development branch:
DEBU[0000] current repository status 'DIRTY' not matched by release type 'integration' matchWorkspaceStatus filter 'CLEAN'. Skipping release type 'integration'
This hints to uncommitted files in the workspace, but there are none (i.e. clean status).
Could you explain?
Log file: infer-debug.txt
Steps to reproduce:
The text was updated successfully, but these errors were encountered: