Add debug and clone to Font and its types.
#56
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ended up effecting more types than I initially anticipated, which theoretically has the most minor of effects of compiles times, or binary size, depending on if the impls are used by users. However, it's just difficult to integrate `Font` into a larger game engine which assumes that assets will implement Debug.
|
In retrospect, I'm apprehensive about debug: It'll leak internal state that probably should be visible. A manual debug implementation would be the right path over a blanket macro definition. |
|
Bumped it and added macro support for small and reasonable things which are already available by getters. Right now, we can't indicate that we didn't debug everything because we don't have What do you think? |
|
This is basically added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ended up effecting more types than I initially anticipated, which theoretically has the most minor of effects of compiles times,
or binary size, depending on if the impls are used by users.
However, it's just difficult to integrate
Fontinto a larger game engine which assumesthat assets will implement Debug.