Cherrypick precompiles fixes #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
polkadot-evm#963 and polkadot-evm#964 can be cherry pick on our branch The purpose of this PR is to merge polkadot-evm#961 on our fork without waiting upstream merge. |
I fixed the template compilation |
|
@nanocryk can you add some rust unit tests that check the good behavior of these precompiles with some hardcoded inputs? |
|
Added tests for ecrecover. The other 2 changes already have tests (changed an existing test that was non-compliant for modexp padding, and added a new test with hardcoded input for modexp gas used) |
librelois
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upstream PR: polkadot-evm#961