Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Weights, RefTime, ProofSize, RocksDB changes #1001

Merged
merged 23 commits into from
Oct 18, 2024

Conversation

themacexpert
Copy link
Contributor

Description

  • Addresses XCM Fee-Related Changes for EVM foreign assets and more.
  • There will be a follow up PR to remove Asset Manager Calls to use new Pallet XCM Weight Trader (for the sake of keeping this PR reasonably sized, that will be a diff one.)

Checklist

  • I have added a label to this PR 🏷️
  • I have run my changes through Grammarly
  • If this requires translations for the moonbeam-docs-cn repo, I have created a ticket for the translations in Jira
  • If pages have been moved around, I have created an additional PR in moonbeam-mkdocs to update redirects
  • If pages have been moved around, I have run the move-pages.py script to move the pages and update the image paths on the chinese repo
    • After the script has been run, I have created an additional PR in moonbeam-docs-cn
  • If images have been added, I have run the compress-images.py script to compress the images.
  • If variables (in variables.yml) need to be updated (such as a name change), I have updated the moonbeam-docs-cn repo to use the new variables
  • If this page requires a disclaimer, I have added one

Corresponding PRs

Please link to any corresponding PRs here.

After Translation Requirements

  • Will need to create PR in moonbeam-docs repo to remove images
  • Will need to create PR in moonbeam-docs repo to remove variables
  • Will need to create PR in moonbeam-mkdocs repo to add redirects for Chinese site
  • No additional PRs are required after the translations are done

Items to be Updated

Please list any of the items that will need to be added or deleted after the translations are done here.

@themacexpert themacexpert marked this pull request as draft September 27, 2024 00:46
@themacexpert themacexpert added the A1 - Maintenance Major Pull request contains major updates to an existing page (i.e., adding a new section, reorgs, etc.) label Sep 27, 2024
@themacexpert themacexpert mentioned this pull request Sep 27, 2024
13 tasks
@themacexpert themacexpert marked this pull request as ready for review September 27, 2024 22:56
Copy link
Contributor

@albertov19 albertov19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I feel the XCM Fees section is a bit hard to follow.

I would lean a lot more on the XCM Runtime API for tutorials, so that you set values according to what the runtime API returns

builders/interoperability/xcm/send-execute-xcm.md Outdated Show resolved Hide resolved
learn/core-concepts/tx-fees.md Outdated Show resolved Hide resolved
learn/core-concepts/tx-fees.md Outdated Show resolved Hide resolved
themacexpert and others added 5 commits October 17, 2024 08:27
Co-authored-by: albertov19 <64150856+albertov19@users.noreply.github.com>
Copy link
Contributor

@albertov19 albertov19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

As a follow up ticket we should ensure that all XCM related tutorials now use the query runtime API for things tbh

@albertov19 albertov19 merged commit 1630fdb into master Oct 18, 2024
1 check passed
@albertov19 albertov19 deleted the themacexpert/weights branch October 18, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A1 - Maintenance Major Pull request contains major updates to an existing page (i.e., adding a new section, reorgs, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants